Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PAYMCLOUD-197] new kubernetes event exporter filter on module v3 #398

Merged

Conversation

ffppa
Copy link
Contributor

@ffppa ffppa commented Jan 8, 2025

List of changes

Refined indentation and YAML structure for better readability in Kubernetes event exporter configurations. Resolved issues with incorrect indentation and aligning with expected syntax.

Motivation and context

Type of changes

  • Add new module
  • Update existing module
  • Remove existing module

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

ffppa added 6 commits January 8, 2025 10:17
Added new routing logic for events based on severity and reasons, including CrashLoopBackOff, OOMKilled, and probe failures, with targeted receivers like Slack and Opsgenie. Introduced log level configuration for better control over log verbosity. Adjustments ensure more granular control and actionable notifications for critical issues.
Reorganized regex patterns into distinct list entries for better readability and maintainability. This change ensures clearer separation of match conditions, adhering to a more structured configuration format.
Consolidated repetitive match conditions into a more concise format using regex and single-line patterns. This reduces redundancy and improves maintainability while preserving functionality for event routing.
Adjusted alert routing rules to separate "CrashLoopBackOff," "OOMKilled," "Liveness probe failed," and "Readiness probe failed" events. Ensured specific events are routed to Slack or Opsgenie, while others are dropped to reduce noise. This improves clarity and maintainability of notification rules.
Replaced dashes with consistent indentation for improved readability and YAML structure accuracy. This adjustment ensures proper rendering and interpretation of templated match conditions.
Updated the drop rules in the YAML structure to ensure proper formatting under the `match` section. This resolves issues with the incorrect indentation, aligning with the expected syntax for Kubernetes event exporter configurations.
@ffppa ffppa requested review from a team as code owners January 8, 2025 10:05
@ffppa ffppa merged commit 08bfcfa into main Jan 8, 2025
4 checks passed
@ffppa ffppa deleted the PAYMCLOUD-197-new-kubernetes-event-exporter-filter-on-module-v3 branch January 8, 2025 10:05
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 8.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant